Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: ica in ibc v7.2.0 is not adjust correctly #1165

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Problem: ica in ibc v7.2.0 is not adjust correctly #1165

merged 5 commits into from
Sep 15, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Sep 13, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #1165 (d0ff507) into main (98c3d06) will increase coverage by 0.48%.
The diff coverage is 20.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
+ Coverage   33.53%   34.01%   +0.48%     
==========================================
  Files         113      112       -1     
  Lines       11076    11051      -25     
==========================================
+ Hits         3714     3759      +45     
+ Misses       6990     6914      -76     
- Partials      372      378       +6
Files Changed Coverage Δ
x/icaauth/keeper/keeper.go 18.75% <0.00%> (+2.67%) ⬆️
x/icaauth/module_ibc.go 14.28% <ø> (+1.78%) ⬆️
x/icaauth/module.go 53.84% <25.00%> (-1.26%) ⬇️

... and 5 files with indirect coverage changes

@mmsqe mmsqe changed the title Problem: icaauth route is not registered correctly Problem: ica in ibc v7.2.0 is not adjust correctly Sep 14, 2023
@mmsqe mmsqe marked this pull request as ready for review September 14, 2023 14:31
@mmsqe mmsqe requested a review from a team as a code owner September 14, 2023 14:31
@mmsqe mmsqe requested review from yihuang and leejw51crypto and removed request for a team September 14, 2023 14:31
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 14, 2023
View reviewed changes
x/icaauth/keeper/keeper.go
@@ -79,7 +66,7 @@
// timeoutDuration should be constraited by MinTimeoutDuration parameter.
timeoutTimestamp := ctx.BlockTime().Add(timeoutDuration).UnixNano()

_, err = k.icaControllerKeeper.SendTx(ctx, channelCapability, connectionID, portID, packetData, uint64(timeoutTimestamp)) //nolint:staticcheck
_, err = k.icaControllerKeeper.SendTx(ctx, nil, connectionID, portID, packetData, uint64(timeoutTimestamp)) //nolint:staticcheck

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
mmsqe
mmsqe commented Sep 14, 2023
View reviewed changes
integration_tests/test_ica.py Outdated Show resolved Hide resolved
@mmsqe mmsqe added this pull request to the merge queue Sep 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 15, 2023
@mmsqe mmsqe added this pull request to the merge queue Sep 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 15, 2023
@mmsqe mmsqe added this pull request to the merge queue Sep 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 15, 2023
@mmsqe mmsqe added this pull request to the merge queue Sep 15, 2023
Merged via the queue into crypto-org-chain:main with commit 6935b19 Sep 15, 2023
22 of 24 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Apr 19, 2024
Merged
13 tasks
This was referenced Apr 26, 2024
Merged
Merged
Merged
This was referenced Apr 29, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang approved these changes

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto leejw51crypto is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @yihuang